Make ActiveSupport::OrderedHash extractable when using `Array#extract_options!
#2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct_options!` `ActiveSupport::OrderedHash` is actually a subclass of the hash, so it does make sense that it should be extractable from the array list.
josevalim
added a commit
that referenced
this pull request
Sep 3, 2011
Make `ActiveSupport::OrderedHash` extractable when using `Array#extract_options!
|
@josevalim thanks bro. Should this one be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
ActiveSupport::OrderedHashextractable when usingArray#extract_options!ActiveSupport::OrderedHashis actually a subclass of the hash, so it does make sense that it should be extractable from the array list.I think this is a bug, so if there's a backport necessary please let me know. Thanks!